Repository navigation
hack/hero-demo: wire Step 4 custom image task - #672
Closed
itssimrank wants to merge 1 commit into
Closed
itssimrank wants to merge 1 commit into
itssimrank wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires up Step 4 (
step4_custom_image_task) in the v0.1 hero demo harness now that automaticax-task-runnerinjection (#639) and workspace pre-warming (#651) are onmain:hack/hero-demo/task-custom.yaml: Pinspython:3.12@sha256:5411fa1b302c43f510324381162b5f5d0d93b9ee2af538f09d944f0d290ee3cbby digest (using the fullpython:3.12image sohero-demo-wssetup'sgit initsucceeds when sharing the workspace across images).hack/hero-demo/run.sh: Implementsstep4_custom_image_taskto delete any priorhero-demo-custom-task, applytask-custom.yaml(withAX_TIMEOUT=600for first-time image pull/setup), resume it, and wait forState: Completed.hack/hero-demo/README.md: Updates the Step 4 documentation and removes it from the stubbed list.Tested locally against Kind (
ax-e2e):RUN_LIVE_STEPS=1 ./hack/hero-demo/run.sh --step 2->🟢 PASSRUN_LIVE_STEPS=1 ./hack/hero-demo/run.sh --step 4->🟢 PASS(Ran 1 test in 0.000s,OK,exitCode=0)./hack/hero-demo/run.sh(dry-run) -> exits0